Glasgow | 26-ITP-May | Niangh Ciang | Sprint 2 | WireFrame#1342
Open
Niangh-Ciang wants to merge 11 commits into
Open
Glasgow | 26-ITP-May | Niangh Ciang | Sprint 2 | WireFrame#1342Niangh-Ciang wants to merge 11 commits into
Niangh-Ciang wants to merge 11 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Niangh-Ciang
added
📅 Sprint 2
cjyuan
added
Review in progress
cjyuan
reviewed
May 28, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code is well formatted and error free. Page layout is solid. Well done!
I have a few requests:
- The footer content and the article content can overlap. Can you prevent it from happening?
-
Can you take a look at this cheatsheet and update the "Changelist" heading in the PR description?
-
To better match the wireframe, can you align the titles and height of the images between articles 2 and 3?
cjyuan
added
Reviewed
Author
|
I’ve made all the updates:
|
Niangh-Ciang
added
the
Needs Review
Contributor
|
Changes look good. Well done! |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
I built the entire webpage according to the wireframe, using semantic HTML, external CSS, three unique articles, a fixed footer, and accessibility‑friendly design, and I ensured the final layout matches the project requirements.
Achieved a 100% Accessibility score in the Lighthouse audit to confirm the page meets high accessibility standards.